Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented vines #578

Merged
merged 24 commits into from
Dec 29, 2024
Merged

Implemented vines #578

merged 24 commits into from
Dec 29, 2024

Conversation

JustTalDevelops
Copy link
Member

Closes #572.

@JustTalDevelops JustTalDevelops added the feature New feature or request label Jul 19, 2022
@JustTalDevelops JustTalDevelops changed the title Implemented vines. Implemented vines Jul 19, 2022
@JustTalDevelops JustTalDevelops mentioned this pull request Jul 19, 2022
Open
89 tasks
DaPigGuy
DaPigGuy reviewed Jul 21, 2022
View reviewed changes
server/block/vine.go Outdated Show resolved Hide resolved
@JustTalDevelops JustTalDevelops added the awaiting response More information is required to resolve and/or close the issue label Jul 22, 2022
@JustTalDevelops JustTalDevelops removed the awaiting response More information is required to resolve and/or close the issue label Jul 24, 2022
@JustTalDevelops JustTalDevelops requested a review from DaPigGuy July 24, 2022 03:50
DaPigGuy
DaPigGuy requested changes Jul 24, 2022
View reviewed changes
server/block/vine.go Outdated Show resolved Hide resolved
server/block/vine.go Show resolved Hide resolved
server/block/vine.go Outdated Show resolved Hide resolved
@JustTalDevelops JustTalDevelops added the awaiting response More information is required to resolve and/or close the issue label Jul 24, 2022
@DaPigGuy DaPigGuy self-requested a review December 16, 2022 20:35
@DaPigGuy DaPigGuy removed the awaiting response More information is required to resolve and/or close the issue label Dec 20, 2024
@DaPigGuy DaPigGuy removed their request for review December 20, 2024 12:27
@DaPigGuy DaPigGuy requested a review from Sandertv December 20, 2024 12:31
@DaPigGuy DaPigGuy marked this pull request as draft December 23, 2024 15:05
@DaPigGuy DaPigGuy marked this pull request as ready for review December 24, 2024 03:19
Sandertv
Sandertv reviewed Dec 28, 2024
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Got one comment on a method that should probably be renamed, but otherwise no major concerns. Feel free to merge if nothing is left to do and all is tested.

server/block/vine.go Outdated Show resolved Hide resolved
@DaPigGuy DaPigGuy merged commit e324031 into master Dec 29, 2024
4 checks passed
@DaPigGuy DaPigGuy deleted the feature/vines branch December 29, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandertv Sandertv Sandertv left review comments

@DaPigGuy DaPigGuy DaPigGuy requested changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement vines
3 participants
@JustTalDevelops @DaPigGuy @Sandertv